Repository navigation
ci: lint test targets as well as the library and binary - #10
Merged
Merged
Conversation
aeddi
marked this pull request as ready for review
November 4, 2026 11:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI's clippy job now lints test code as well as the library and binary. It ran
cargo clippy --all-features, which never compiles test targets — which is how twodeny-level
unused_io_amounterrors intests/cli/mod.rssurvived from 2018 until #6'sreview caught them; #8 fixed them.
Turning
--all-targetson surfaced five more warnings, all intests/integration.rs. Theyare fixed here, so the job passes under the workflow's
RUSTFLAGS: -Dwarnings.The documented lint command now matches CI's. The README's was plain
cargo clippy, whichhas never worked on this fork: with no default backend feature it stops at the
compile_error!insrc/lib.rs.Changes
KmsSocket::{TCP, UNIX}to{Tcp, Unix}, matching the siblingKmsConnection—b765765SecretConnectionvariant, 448 bytes against the other variant's 4 —cb1eef3c43583d--all-targetsto CI's clippy job —74f3311FORK.md—08c4ebfTesting
RUSTFLAGS=-Dwarnings cargo +1.89.0 clippy --all-features --all-targets: clean. On thebase before fix(tests): write captured output in full when a command fails #8 it reported 7 errors.
needless_borrowfails it.boxed types.